This pull request contains fix to MMRecord batch request issue #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnstoll
added a commit
that referenced
this pull request
May 8, 2013
This pull request contains fix to MMRecord batch request issue
|
Awesome!! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem : "startBatchedRequest.." method is failing to call completionBlock(), when one/all of the API call gets failed.
Solution: I gone through the MMRecord batch request code and found that MMRecord is not calling "dispatch_group_leave(state.dispatchGroup);" in faillure block. In this pull request I have added code which informs the DispatchGroup that task has been completed by calling "dispatch_group_leave", this way completionBlock() is getting called when all of its batch request completes their execution regardless of their results.