fix: notification to channel language #1133
Conversation
|
What does twitch translate the tiers as? It should match the labeling they use since they are more like proper nouns. |
muxfd subscribed at Tier 1. They've subscribed for 10 months! or muxfd subscribed at Tier 1. They've subscribed for 10 months, currently on a 10 month streak! Should probably also think about exposing the streak amount maybe as well. |
| TextSpan( | ||
| text: model.total > 1 ? "subscriptions. " : "subscription. "), |
There was a problem hiding this comment.
Do you know what this part of the logic was I don't remember off the top of my head, would like to make the translation part more descriptive for our translators.
There was a problem hiding this comment.
This won't work with translations as some languages don't let you composite like this. See https://docs.flutter.dev/ui/accessibility-and-internationalization/internationalization#placeholders-plurals-and-selects
We'll need to bake the pluralization into the translation string itself.
|
The subscription message I will investigate into as a separate PR. |
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
This aims to resolve #919
I need this looked over first also probably want to update all the translation messages in this PR.