fix: update key and lints #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmo314
approved these changes
Jan 2, 2024
| @@ -13,14 +13,13 @@ class DecoratedEventWidget extends StatelessWidget { | |||
| final EdgeInsets padding; | |||
|
|
|||
| const DecoratedEventWidget._( | |||
| {Key? key, | |||
| {super.key, | |||
There was a problem hiding this comment.
Is this what dart fmt spits out? It's fine if so, but a little surprised.
There was a problem hiding this comment.
Yeah dart format nor the analyzer throw me any errors at all, if I do try and correct it to the previous way the latest analyzer warns me to change it again.
| @@ -36,11 +36,9 @@ class TwitchPredictionEventWidget extends StatelessWidget { | |||
|
|
|||
| class _TwitchOutcomeWidget extends StatelessWidget { | |||
| const _TwitchOutcomeWidget( | |||
| {Key? key, | |||
| required this.outcome, | |||
| {required this.outcome, | |||
There was a problem hiding this comment.
A value for optional parameter 'key' isn't ever given.
Try removing the unused parameter.
| @@ -11,8 +11,7 @@ class _DurationWidget extends StatelessWidget { | |||
| final DateTime from; | |||
| final TextStyle? style; | |||
|
|
|||
| const _DurationWidget({Key? key, this.style, required this.from}) | |||
| : super(key: key); | |||
| const _DurationWidget({this.style, required this.from}); | |||
There was a problem hiding this comment.
A value for optional parameter 'key' isn't ever given.
Try removing the unused parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.