-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable tts when stream goes offline #1193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I tested it on both physical/virtual android it is behaving correctly, although not sure how to simulate a stream going offline.
Edit: Doesn't disable notification or tts when stream dies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, logic looks good just a few cleanup points.
…UI to change when the channel stream is nothing/null
…es offline fix: a bug that could happen when there was no message of type 'message'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, make sure the notifications change gets looped in with @SputNikPlop's work, otherwise this looks great.
No description provided.