Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable tts when stream goes offline #1193

Merged
merged 18 commits into from
Mar 5, 2024
Merged

fix: disable tts when stream goes offline #1193

merged 18 commits into from
Mar 5, 2024

Conversation

SputNikPlop
Copy link
Collaborator

No description provided.

@SputNikPlop SputNikPlop linked an issue Jan 19, 2024 that may be closed by this pull request
@SputNikPlop SputNikPlop changed the title fix: disable when stream goes offline fix: disable tts when stream goes offline Jan 19, 2024
lib/models/tts.dart Outdated Show resolved Hide resolved
lib/tts_isolate.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@jessielw jessielw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested it on both physical/virtual android it is behaving correctly, although not sure how to simulate a stream going offline.

Edit: Doesn't disable notification or tts when stream dies.

Copy link
Contributor

@kevmo314 kevmo314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, logic looks good just a few cleanup points.

lib/screens/home.dart Outdated Show resolved Hide resolved
lib/screens/home.dart Outdated Show resolved Hide resolved
lib/screens/home.dart Outdated Show resolved Hide resolved
lib/screens/home.dart Outdated Show resolved Hide resolved
@jessielw jessielw requested a review from kevmo314 March 5, 2024 23:03
Copy link
Contributor

@kevmo314 kevmo314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, make sure the notifications change gets looped in with @SputNikPlop's work, otherwise this looks great.

lib/tts_isolate.dart Outdated Show resolved Hide resolved
@jessielw jessielw merged commit 25845e8 into main Mar 5, 2024
4 checks passed
@jessielw jessielw deleted the 1185 branch March 5, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable TTS when stream goes offline
3 participants