Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update localization files to retain 'Hype Train' as a proper noun #1286

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

kevmo314
Copy link
Contributor

@kevmo314 kevmo314 commented Jul 8, 2024

Update localization files to retain "Hype Train" as a proper noun instead of translating it for languages with Latin scripts.

  • Modify lib/l10n/app_de.arb to retain "Hype Train" as a proper noun in the keys: "hypetrainEventConfigTitle", "customizeYourHypetrainEvent", "hypeTrainEventProgress", "hypeTrainEventEndedSuccessful", "hypeTrainEventEndedUnsuccessful".
  • Modify lib/l10n/app_es.arb to retain "Hype Train" as a proper noun in the keys: "hypetrainEventConfigTitle", "customizeYourHypetrainEvent", "hypeTrainEventProgress", "hypeTrainEventEndedSuccessful", "hypeTrainEventEndedUnsuccessful".
  • Modify lib/l10n/app_fr.arb to retain "Hype Train" as a proper noun in the keys: "hypetrainEventConfigTitle", "customizeYourHypetrainEvent", "hypeTrainEventProgress", "hypeTrainEventEndedSuccessful", "hypeTrainEventEndedUnsuccessful".
  • Modify lib/l10n/app_it.arb to retain "Hype Train" as a proper noun in the keys: "hypetrainEventConfigTitle", "customizeYourHypetrainEvent", "hypeTrainEventProgress", "hypeTrainEventEndedSuccessful", "hypeTrainEventEndedUnsuccessful".
  • Modify lib/l10n/app_nl.arb to retain "Hype Train" as a proper noun in the keys: "hypetrainEventConfigTitle", "customizeYourHypetrainEvent", "hypeTrainEventProgress", "hypeTrainEventEndedSuccessful", "hypeTrainEventEndedUnsuccessful".
  • Modify lib/l10n/app_pt.arb to retain "Hype Train" as a proper noun in the keys: "hypetrainEventConfigTitle", "customizeYourHypetrainEvent", "hypeTrainEventProgress", "hypeTrainEventEndedSuccessful", "hypeTrainEventEndedUnsuccessful".

For more details, open the Copilot Workspace session.

@SputNikPlop
Copy link
Collaborator

Lemme ask about this and see what the twitch website behavior is

@SputNikPlop
Copy link
Collaborator

@kevmo314 This is fine as is for all languages but French and Spanish

@SputNikPlop SputNikPlop enabled auto-merge (squash) July 9, 2024 07:05
@SputNikPlop SputNikPlop merged commit e280ebb into main Jul 9, 2024
7 checks passed
@SputNikPlop SputNikPlop deleted the kevmo314/update-localization branch July 9, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants