Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add explicit sign in button and use bottom sheet #377

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

kevmo314
Copy link
Contributor

No description provided.

@kevmo314 kevmo314 enabled auto-merge (squash) April 27, 2022 14:04
Copy link
Collaborator

@juaoose juaoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the new button have alignment for its text? Since its rather long it might not fit one line?

Somewhat related: Should we expand the bottom sheet to 100% height when keyboard is open? It looks weird on smaller devices.

I think this fixes the overflow I was experiencing on a smaller display.

@kevmo314
Copy link
Contributor Author

Should the new button have alignment for its text? Since its rather long it might not fit one line?

I think center aligned looks ok, what do you think?

Somewhat related: Should we expand the bottom sheet to 100% height when keyboard is open? It looks weird on smaller devices.

Yeah we should probably do this. So many edge cases >.<

@juaoose
Copy link
Collaborator

juaoose commented Apr 27, 2022

I think center aligned looks ok, what do you think?

Yeah center alignment I think is nice, I think right now it's to the left because mainAxisAlignment for Column is vertical, right?

@kevmo314
Copy link
Contributor Author

Yeah center alignment I think is nice, I think right now it's to the left because mainAxisAlignment for Column is vertical, right?

I'm confused, can you point to the code change you're proposing? Isn't the column's alignment already set to center?

@kevmo314 kevmo314 merged commit e5de25c into main Apr 27, 2022
@kevmo314 kevmo314 deleted the tweak-onboarding branch April 27, 2022 20:07
@juaoose juaoose mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants