-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add explicit sign in button and use bottom sheet #377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the new button have alignment for its text? Since its rather long it might not fit one line?
Somewhat related: Should we expand the bottom sheet to 100% height when keyboard is open? It looks weird on smaller devices.
I think this fixes the overflow I was experiencing on a smaller display.
I think center aligned looks ok, what do you think?
Yeah we should probably do this. So many edge cases >.< |
Yeah center alignment I think is nice, I think right now it's to the left because mainAxisAlignment for Column is vertical, right? |
I'm confused, can you point to the code change you're proposing? Isn't the column's alignment already set to center? |
No description provided.