Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update search viewers #485

Merged
merged 7 commits into from
Jun 15, 2022
Merged

style: update search viewers #485

merged 7 commits into from
Jun 15, 2022

Conversation

KeN095
Copy link
Collaborator

@KeN095 KeN095 commented Jun 7, 2022

Screenshot_1654558662

Closes #334

@KeN095
Copy link
Collaborator Author

KeN095 commented Jun 7, 2022

You might notice it, but there isn't consistency in how the divider color is despite it having the same color code. Don't know why but I hope it's just a debug issue.

@cswills
Copy link
Collaborator

cswills commented Jun 7, 2022

You might notice it, but there isn't consistency in how the divider color is despite it having the same color code. Don't know why but I hope it's just a debug issue.

I think that's because the divider is one pixel high but it is rendered over two pixels.

lib/components/drawer/end_drawer.dart Outdated Show resolved Hide resolved
lib/components/drawer/end_drawer.dart Outdated Show resolved Hide resolved
lib/components/drawer/end_drawer.dart Outdated Show resolved Hide resolved
@KeN095
Copy link
Collaborator Author

KeN095 commented Jun 15, 2022

The divider had erratic results in testing even by making a divider through Container with BoxDecoration with only a bottom border.

Each divider had lighter or darker color than the one before it and would also disappear in the middle of scrolling, regardless of light/dark theme.

Sometimes the coloring of the divider would be fixed if you close and open the Search viewers page but was better to remove it for consistent UI in the end.

@KeN095 KeN095 merged commit 758c416 into main Jun 15, 2022
@KeN095 KeN095 deleted the style-search-viewers branch June 15, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[style] update viewer page style
3 participants