Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow tts to play in the background on ios #927

Merged
merged 2 commits into from
Feb 1, 2023
Merged

feat: allow tts to play in the background on ios #927

merged 2 commits into from
Feb 1, 2023

Conversation

juaoose
Copy link
Collaborator

@juaoose juaoose commented Feb 1, 2023

These apis seem to change between iOS versions which is why I excluded some of the common options, tested on 16.0

SputNikPlop
SputNikPlop approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@SputNikPlop SputNikPlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think when more people upgrade their iOS then we can tweak more options slowly. Worked ok even on iPhone 5s, tested on iPhone 13 iOS 15/16 worked fine as well.

@juaoose juaoose merged commit d8120dc into main Feb 1, 2023
@juaoose juaoose deleted the ios-bg-tts branch February 1, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SputNikPlop SputNikPlop SputNikPlop approved these changes

@kevmo314 kevmo314 Awaiting requested review from kevmo314

@cswills cswills Awaiting requested review from cswills

@chungwwei chungwwei Awaiting requested review from chungwwei

@KeN095 KeN095 Awaiting requested review from KeN095

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juaoose @SputNikPlop