Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: branding for ios #939

Merged
merged 11 commits into from
Feb 14, 2023
Merged

feat: branding for ios #939

merged 11 commits into from
Feb 14, 2023

Conversation

SputNikPlop
Copy link
Collaborator

Screen Shot 2023-02-07 at 8 24 07 AM

@SputNikPlop SputNikPlop linked an issue Feb 7, 2023 that may be closed by this pull request
[app] add branding for iOS devices #911
Closed
@kevmo314
Copy link
Contributor

kevmo314 commented Feb 7, 2023

Can the logo be moved up a bit? It's too close to the bottom right now.

@SputNikPlop
Copy link
Collaborator Author

Can the logo be moved up a bit? It's too close to the bottom right now.

Sure thing! I assume you want it below the app logo, but do you have an ideal location or height you want me to set it at?

@SputNikPlop
Copy link
Collaborator Author

Screen Shot 2023-02-07 at 2 56 17 PM copy
@kevmo314 The blue box is what the branch is set at, I can move it to any of the numbered positions (1,2,3) depending on what you think is best. I will also fix it for the other apps once this PR is merged.

@kevmo314
Copy link
Contributor

kevmo314 commented Feb 8, 2023

Screen Shot 2023-02-07 at 2 56 17 PM copy @kevmo314 The blue box is what the branch is set at, I can move it to any of the numbered positions (1,2,3) depending on what you think is best. I will also fix it for the other apps once this PR is merged.

Let's set it to position 3

@SputNikPlop
Copy link
Collaborator Author

Screen Shot 2023-02-14 at 1 17 23 PM
@kevmo314 Does this look good for merge?

@SputNikPlop SputNikPlop merged commit 77cb1cf into main Feb 14, 2023
@SputNikPlop SputNikPlop deleted the ios branch February 14, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmo314 kevmo314 kevmo314 approved these changes

@juaoose juaoose Awaiting requested review from juaoose

@KeN095 KeN095 Awaiting requested review from KeN095

@chungwwei chungwwei Awaiting requested review from chungwwei

@cswills cswills Awaiting requested review from cswills

Assignees
No one assigned
Labels
codeball:needs-careful-review Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[app] add branding for iOS devices
2 participants
@SputNikPlop @kevmo314