-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: audio track API for 1 track (#776)
reverts a bug fix in #759 it was a good patch but it prevented the audio tracks API to be populated if there was just 1 audio track. it's still expected that with 1 audio track, the API returns an item for video.audioTracks[0]. this change adds that back in. the root issue in hls.js I believe was that we were trying to select an audio track with a string ID and hls.js works with numeric ID's. this change also adds a check if hls.js audioTracks has the ID to which the player tries to switch.
- Loading branch information
Showing
2 changed files
with
11 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4222fd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
elements-demo-vue – ./examples/vue-with-typescript
elements-demo-vue-mux.vercel.app
elements-demo-vue.vercel.app
elements-demo-vue-git-main-mux.vercel.app
4222fd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
elements-demo-svelte-kit – ./examples/svelte-kit
elements-demo-svelte-kit-mux.vercel.app
elements-demo-svelte-kit-git-main-mux.vercel.app
elements-demo-svelte-kit.vercel.app
4222fd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
elements-demo-create-react-app – ./examples/create-react-app-with-typescript
elements-demo-create-react-app-git-main-mux.vercel.app
elements-demo-create-react-app.vercel.app
elements-demo-create-react-app-mux.vercel.app
4222fd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
elements-demo-nextjs – ./examples/nextjs-with-typescript
elements-demo-nextjs.vercel.app
elements-demo-nextjs-mux.vercel.app
elements-demo-nextjs-git-main-mux.vercel.app
4222fd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
elements-demo-vanilla – ./examples/vanilla-ts-esm
elements-demo-vanilla-mux.vercel.app
elements-demo-vanilla.vercel.app
elements-demo-vanilla-git-main-mux.vercel.app