fix: audio track API for 1 track #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 82.18% 82.16% -0.02%
==========================================
Files 40 40
Lines 7862 7868 +6
Branches 456 456
==========================================
+ Hits 6461 6465 +4
- Misses 1395 1397 +2
Partials 6 6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts a bug fix in #759
it was a good patch but it prevented the audio tracks API to be populated if there was just 1 audio track.
it's still expected that with 1 audio track, the API returns an item for video.audioTracks[0].
this change adds that back in.
the root issue in hls.js I believe was that we were trying to select an audio track with a string ID and hls.js works with numeric ID's.
this change also adds a check if hls.js audioTracks has the ID to which the player tries to switch.