Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom media element seek issue on v3 #858

Closed
luwes opened this issue Mar 18, 2024 · 0 comments · Fixed by #861
Closed

custom media element seek issue on v3 #858

luwes opened this issue Mar 18, 2024 · 0 comments · Fixed by #861
Assignees
@luwes
Labels
bug Something isn't working

Comments

@luwes
Copy link
Contributor

luwes commented Mar 18, 2024

seeking via the bottom media chrome player doesn't work anymore with media-chrome v3

https://spotify-audio-element.vercel.app/
@luwes luwes added the bug Something isn't working label Mar 18, 2024
@luwes luwes self-assigned this Mar 22, 2024
luwes added a commit to luwes/media-chrome that referenced this issue Mar 22, 2024
@luwes
fix: seek on custom media w/o readyState
83af8d4 
fix muxinc#858
@luwes luwes mentioned this issue Mar 22, 2024
Merged
luwes added a commit to luwes/media-chrome that referenced this issue Mar 22, 2024
@luwes
fix: seek on custom media w/o readyState
11dcf38 
fix muxinc#858
luwes added a commit that referenced this issue Mar 26, 2024
@luwes
fix: seek on custom media w/o readyState (#861)
5a96ba1 
fix #858

regression introduced in 
#784

old logic here

https://github.com/muxinc/media-chrome/pull/835/files#diff-f47c60f82e0b188cc72db120e2829c4473753d20186183b4c2e1492169d61321L806-L810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luwes luwes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: seek on custom media w/o readyState luwes/media-chrome
1 participant
@luwes