Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: remove unneeded media-loading attr #498

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Mar 9, 2023

this attribute is unneeded as far as I can tell. it will be propagated by the waiting event

'waiting,playing,emptied': () => {
const isLoading = this.media?.readyState < 3;
this.propagateMediaState(MediaUIAttributes.MEDIA_LOADING, isLoading);
},

@luwes luwes requested review from a team and heff as code owners March 9, 2023 23:54
@luwes luwes self-assigned this Mar 9, 2023
@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 9:03PM (UTC)
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 9:03PM (UTC)

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #498 (f6de6a4) into main (56b549c) will not change coverage.
The diff coverage is n/a.

❗ Current head f6de6a4 differs from pull request most recent head 28ad22c. Consider uploading reports for the commit 28ad22c to get more accurate results

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   75.19%   75.19%           
=======================================
  Files          43       43           
  Lines        6870     6870           
=======================================
  Hits         5166     5166           
  Misses       1704     1704           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luwes
Copy link
Contributor Author

luwes commented Mar 13, 2023

going w/ bias for action here and merge. only touches examples and we don't use this attribute in Mux player. very sure this attribute is not needed.

@luwes luwes merged commit 0dd3e05 into muxinc:main Mar 13, 2023
@luwes luwes deleted the remove-media-loading branch March 13, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant