fix: invert API for the smart cache #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjl-mux
force-pushed
the
ajlb/fix/invert-api-for-smart-cache
branch
from
a8fbe88
to
e952925
Compare
daytime-em
approved these changes
Feb 23, 2024
andrewjl-mux
force-pushed
the
ajlb/fix/invert-api-for-smart-cache
branch
from
e952925
to
5fa1970
Compare
andrewjl-mux
added a commit
that referenced
this pull request
May 8, 2024
andrewjl-mux
added a commit
that referenced
this pull request
May 8, 2024
commit d83a9aca216c77ea8997bd6111165c6cf5019e4e
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Mon May 6 19:28:48 2024 -0700
fix customer data passthrough to data
commit 8048f53fde6f32552835e159a46f641b55b161cb
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Mon May 6 19:28:27 2024 -0700
fix asc
commit 4e673dec1858d0b8f08160abfed0873370da0396
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Mon May 6 19:28:15 2024 -0700
experiments
commit cff3c873a33182755eff6326bdfa1250a4b0b191
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Fri May 3 14:41:32 2024 -0700
configurable playback modifiers when testing cache
commit 2e3d21e
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Fri May 3 13:42:44 2024 -0700
configrable playback modifiers in example
commit e013cc3
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Thu May 2 14:02:09 2024 -0700
fix: cache error fallback (#38)
* build: update Data SDK
* [NFC] reverse proxy cleanup
* use Foundation APIs to extract origin URL query value
commit a642a87
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Fri Apr 26 12:19:43 2024 -0700
fix: add extra percent encoding to avoid origin url truncation (#37)
* fix: add extra percent encoding to avoid origin url truncation
* fix tests
commit 47cfaf7
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Fri Feb 23 16:24:39 2024 -0800
fix: invert API for the smart cache (#32)
commit efdeee0
Author: Christian Pillsbury <cjpillsbury@gmail.com>
Date: Fri Feb 16 08:50:51 2024 -0800
fix: Add basic cmaf support. (#31)
commit f03a419
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Tue Feb 13 14:45:59 2024 -0800
chore: emit SDK diagnostics into unified logging system (#30)
commit 4d56d11
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Tue Feb 13 11:54:41 2024 -0800
feat: HLS proxy server and URLCache integration (#24)
* fix: expose initializers (#26)
* feat: reverse proxy server
* test: add additional ui for testing
* use URLCache built-in as storage
* chore: add basic ABR observation
* chore: extract manifest processing to separate class, log cache size and segment size
* chore: rename playlist parsing to reflect technical definitions and purpose (including tests) (#27)
* test: account for percent encoding when checking URLs in query params
---------
Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com>
andrewjl-mux
added a commit
that referenced
this pull request
May 8, 2024
andrewjl-mux
added a commit
that referenced
this pull request
May 8, 2024
commit d83a9aca216c77ea8997bd6111165c6cf5019e4e
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Mon May 6 19:28:48 2024 -0700
fix customer data passthrough to data
commit 8048f53fde6f32552835e159a46f641b55b161cb
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Mon May 6 19:28:27 2024 -0700
fix asc
commit 4e673dec1858d0b8f08160abfed0873370da0396
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Mon May 6 19:28:15 2024 -0700
experiments
commit cff3c873a33182755eff6326bdfa1250a4b0b191
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Fri May 3 14:41:32 2024 -0700
configurable playback modifiers when testing cache
commit 2e3d21e
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Fri May 3 13:42:44 2024 -0700
configrable playback modifiers in example
commit e013cc3
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Thu May 2 14:02:09 2024 -0700
fix: cache error fallback (#38)
* build: update Data SDK
* [NFC] reverse proxy cleanup
* use Foundation APIs to extract origin URL query value
commit a642a87
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Fri Apr 26 12:19:43 2024 -0700
fix: add extra percent encoding to avoid origin url truncation (#37)
* fix: add extra percent encoding to avoid origin url truncation
* fix tests
commit 47cfaf7
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Fri Feb 23 16:24:39 2024 -0800
fix: invert API for the smart cache (#32)
commit efdeee0
Author: Christian Pillsbury <cjpillsbury@gmail.com>
Date: Fri Feb 16 08:50:51 2024 -0800
fix: Add basic cmaf support. (#31)
commit f03a419
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Tue Feb 13 14:45:59 2024 -0800
chore: emit SDK diagnostics into unified logging system (#30)
commit 4d56d11
Author: AJ Lauer Barinov <abarinov@mux.com>
Date: Tue Feb 13 11:54:41 2024 -0800
feat: HLS proxy server and URLCache integration (#24)
* fix: expose initializers (#26)
* feat: reverse proxy server
* test: add additional ui for testing
* use URLCache built-in as storage
* chore: add basic ABR observation
* chore: extract manifest processing to separate class, log cache size and segment size
* chore: rename playlist parsing to reflect technical definitions and purpose (including tests) (#27)
* test: account for percent encoding when checking URLs in query params
---------
Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com>
andrewjl-mux
added a commit
that referenced
this pull request
May 20, 2024
* feat: HLS proxy server and URLCache integration (#24) * test: add additional ui for testing * use URLCache built-in as storage * chore: add basic ABR observation * chore: extract manifest processing to separate class, log cache size and segment size * chore: rename playlist parsing to reflect technical definitions and purpose (including tests) (#27) * test: account for percent encoding when checking URLs in query params --------- Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> * chore: emit SDK diagnostics into unified logging system (#30) * fix: Add basic cmaf support. (#31) * fix: invert API for the smart cache (#32) * fix: add extra percent encoding to avoid origin url truncation (#37) * fix: cache error fallback (#38) * build: update Data SDK
daytime-em
pushed a commit
that referenced
this pull request
May 23, 2024
* feat: expose API for configuring existing player view controllers (#41) * feat: expose API for configuring existing player view controllers to match what is provided for AVPlayerLayer * docs: fixup grammar * fix: remove rendition order ascending (#43) * docs: fixups (#42) * Fix up AVPlayerLayer too * docs: typos * docs: monitoring options improvements * feat: HLS proxy server and URLCache integration (#24) * fix: expose initializers (#26) * feat: reverse proxy server * test: add additional ui for testing * use URLCache built-in as storage * chore: add basic ABR observation * chore: extract manifest processing to separate class, log cache size and segment size * chore: rename playlist parsing to reflect technical definitions and purpose (including tests) (#27) * test: account for percent encoding when checking URLs in query params --------- Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> * chore: emit SDK diagnostics into unified logging system (#30) * fix: Add basic cmaf support. (#31) * fix: invert API for the smart cache (#32) * fix: add extra percent encoding to avoid origin url truncation (#37) * fix: add extra percent encoding to avoid origin url truncation * fix tests * fix: cache error fallback (#38) * build: update Data SDK * [NFC] reverse proxy cleanup * use Foundation APIs to extract origin URL query value * Squashed commit of the following: commit d83a9aca216c77ea8997bd6111165c6cf5019e4e Author: AJ Lauer Barinov <abarinov@mux.com> Date: Mon May 6 19:28:48 2024 -0700 fix customer data passthrough to data commit 8048f53fde6f32552835e159a46f641b55b161cb Author: AJ Lauer Barinov <abarinov@mux.com> Date: Mon May 6 19:28:27 2024 -0700 fix asc commit 4e673dec1858d0b8f08160abfed0873370da0396 Author: AJ Lauer Barinov <abarinov@mux.com> Date: Mon May 6 19:28:15 2024 -0700 experiments commit cff3c873a33182755eff6326bdfa1250a4b0b191 Author: AJ Lauer Barinov <abarinov@mux.com> Date: Fri May 3 14:41:32 2024 -0700 configurable playback modifiers when testing cache commit 2e3d21e Author: AJ Lauer Barinov <abarinov@mux.com> Date: Fri May 3 13:42:44 2024 -0700 configrable playback modifiers in example commit e013cc3 Author: AJ Lauer Barinov <abarinov@mux.com> Date: Thu May 2 14:02:09 2024 -0700 fix: cache error fallback (#38) * build: update Data SDK * [NFC] reverse proxy cleanup * use Foundation APIs to extract origin URL query value commit a642a87 Author: AJ Lauer Barinov <abarinov@mux.com> Date: Fri Apr 26 12:19:43 2024 -0700 fix: add extra percent encoding to avoid origin url truncation (#37) * fix: add extra percent encoding to avoid origin url truncation * fix tests commit 47cfaf7 Author: AJ Lauer Barinov <abarinov@mux.com> Date: Fri Feb 23 16:24:39 2024 -0800 fix: invert API for the smart cache (#32) commit efdeee0 Author: Christian Pillsbury <cjpillsbury@gmail.com> Date: Fri Feb 16 08:50:51 2024 -0800 fix: Add basic cmaf support. (#31) commit f03a419 Author: AJ Lauer Barinov <abarinov@mux.com> Date: Tue Feb 13 14:45:59 2024 -0800 chore: emit SDK diagnostics into unified logging system (#30) commit 4d56d11 Author: AJ Lauer Barinov <abarinov@mux.com> Date: Tue Feb 13 11:54:41 2024 -0800 feat: HLS proxy server and URLCache integration (#24) * fix: expose initializers (#26) * feat: reverse proxy server * test: add additional ui for testing * use URLCache built-in as storage * chore: add basic ABR observation * chore: extract manifest processing to separate class, log cache size and segment size * chore: rename playlist parsing to reflect technical definitions and purpose (including tests) (#27) * test: account for percent encoding when checking URLs in query params --------- Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> * chore: example cleanup * chore: update version * chore: remove debug view * ci: add documentation generation scripts * remove debug view controller * feat: gate smart cache to single rendition playlists * docs: release instructions * docs: fixup single rendition enum descriptions * docs: add the actual release steps * build: update to AVPlayer Data SDK with privacy manifest * start-up reverse proxy only when required include additional examples * SingleResolutionTier -> SingleRenditionResolutionTier * Update installation version in README * remove readme callout and create consolidated script for docs regeneration * fix example * fix capitalization * disable diagnostics logging when in release mode * Separate initialization method for single renditions To help with example in guide. A separate init method rather than a default parameter helps with discoverability of the enableSmartCache option * test: improve tests * chore: expose environment variable accessors * docs: add DRM example scaffolding * add TODO * restart player when example menu options change --------- Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.