Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump for 2.2.2 #49

Merged
merged 7 commits into from
Feb 23, 2021
Merged

Bump for 2.2.2 #49

merged 7 commits into from
Feb 23, 2021

Commits on Feb 23, 2021

  1. Bump for 2.2.2

    @dylanjha
    dylanjha committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    99c8962 View commit details
    Browse the repository at this point in the history

  2. fix race condition in test for abort() method 

    This failed on a test run: https://github.com/muxinc/upchunk/pull/49/checks?check_run_id=1957508634

This commit doesn't fix the race condition, but it makes it less likely
to happen :/ not ideal, but we'll go with it

```
* FAIL src/upchunk.spec.ts
  ● Console

    console.error
      Error: Uncaught [Error: expect(received).toBeTruthy()

      Received: false]
          at reportException (/home/runner/work/upchunk/upchunk/node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:62:24)
          at Timeout.task [as _onTimeout] (/home/runner/work/upchunk/upchunk/node_modules/jsdom/lib/jsdom/browser/Window.js:396:9)
          at listOnTimeout (internal/timers.js:554:17)
          at processTimers (internal/timers.js:497:7) JestAssertionError: expect(received).toBeTruthy()

      Received: false
          at /home/runner/work/upchunk/upchunk/src/upchunk.spec.ts:315:30
          at Timeout.task [as _onTimeout] (/home/runner/work/upchunk/upchunk/node_modules/jsdom/lib/jsdom/browser/Window.js:391:19)
          at listOnTimeout (internal/timers.js:554:17)
          at processTimers (internal/timers.js:497:7) {
        matcherResult: { message: [Function: message], pass: false }
      }

      at VirtualConsole.<anonymous> (node_modules/jsdom/lib/jsdom/virtual-console.js:29:45)
      at reportException (node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:66:28)
      at Timeout.task [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:396:9)
```
    @dylanjha
    dylanjha committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    452997e View commit details
    Browse the repository at this point in the history

  3. make the hacky test slightly less hacky

    @mmcc
    mmcc committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    c92963a View commit details
    Browse the repository at this point in the history

  4. take another stab at fixing this flakey test

    @dylanjha
    dylanjha committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    d36b98b View commit details
    Browse the repository at this point in the history

  5. nock the upload endpoint 2 times, check that only 1 nock gets used

    @dylanjha
    dylanjha committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0a5b062 View commit details
    Browse the repository at this point in the history

  6. remove unused attemptCallback and check the chunkSuccessCallback

    @dylanjha
    dylanjha committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    541d9a7 View commit details
    Browse the repository at this point in the history

  7. use the chunkSuccessCallback spy

    @dylanjha
    dylanjha committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    006ed10 View commit details
    Browse the repository at this point in the history