Bump for 2.2.2 #49
Merged
Bump for 2.2.2 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This failed on a test run: https://github.com/muxinc/upchunk/pull/49/checks?check_run_id=1957508634 This commit doesn't fix the race condition, but it makes it less likely to happen :/ not ideal, but we'll go with it ``` * FAIL src/upchunk.spec.ts ● Console console.error Error: Uncaught [Error: expect(received).toBeTruthy() Received: false] at reportException (/home/runner/work/upchunk/upchunk/node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:62:24) at Timeout.task [as _onTimeout] (/home/runner/work/upchunk/upchunk/node_modules/jsdom/lib/jsdom/browser/Window.js:396:9) at listOnTimeout (internal/timers.js:554:17) at processTimers (internal/timers.js:497:7) JestAssertionError: expect(received).toBeTruthy() Received: false at /home/runner/work/upchunk/upchunk/src/upchunk.spec.ts:315:30 at Timeout.task [as _onTimeout] (/home/runner/work/upchunk/upchunk/node_modules/jsdom/lib/jsdom/browser/Window.js:391:19) at listOnTimeout (internal/timers.js:554:17) at processTimers (internal/timers.js:497:7) { matcherResult: { message: [Function: message], pass: false } } at VirtualConsole.<anonymous> (node_modules/jsdom/lib/jsdom/virtual-console.js:29:45) at reportException (node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:66:28) at Timeout.task [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:396:9) ```
dylanjha
commented
Feb 23, 2021
mmcc
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes fix for #30 from PR #43
Diff: v2.2.1...master