Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to delete packages? #36

Open
victorhooi opened this issue Nov 23, 2012 · 12 comments
Open

Ability to delete packages? #36

victorhooi opened this issue Nov 23, 2012 · 12 comments

Comments

@victorhooi
Copy link

Hi,

Is it possible to expose functionality through the Localshop webinterface that would let you remove packages?

I assume currently you can just delete the files, then remove all of the entries from the DB manually - however, it would be cleaner if this could be done via the Localshop web interface.

Cheers,
Victor

@mvantellingen
Copy link
Owner

Yeah I agree. This needs to be implemented. Will take a look at it asap

@dbrgn
Copy link
Contributor

dbrgn commented Feb 6, 2013

Yes please :) As a workaround, is it enough to remove the package in the admin?

@lovato
Copy link
Collaborator

lovato commented May 10, 2013

Just look out what I described on issue #61. If you remove it, nobody can guarantee that someone already downloaded it, and worse: if you upload a different package (different source code) with same version. We will have inconsistency.

@dbrgn
Copy link
Contributor

dbrgn commented May 10, 2013

The same problem exists on the "real" pypi too, though. It's just something that you shouldn't do.

Removing packages during the testing phase would be great though. It's the users responsibility not to delete packages that other people are already using (similar to force-rewriting public VCS repositories).

@llonchj
Copy link
Collaborator

llonchj commented Jun 20, 2013

Latest development branch contains a menu to access Django admin.

@lovato
Copy link
Collaborator

lovato commented Jun 22, 2013

I have a PROD and DSV localshops. Probaly there can be a switch to enable or not that. Will not remove packages on my production environment. Just increment version, fix it and submit it again. Perhaps the best is to mark the package as bad_package. So no one will be able to download it again. And also never overide it.

@llonchj
Copy link
Collaborator

llonchj commented Jun 22, 2013

I can see your point having 2 localshop instances. As localshop acts also as a pypi proxy, have you considered using only one localshop and specify the version to download in setup.py or requirements.txt?

@lovato
Copy link
Collaborator

lovato commented Jun 24, 2013

The DSV one is intended for testing only. Package creation/upload tests. If the package is well configured, tested and so on, it goes to production.

@lovato
Copy link
Collaborator

lovato commented Sep 4, 2013

DSV version was discontinued :-)

@llonchj
Copy link
Collaborator

llonchj commented Sep 4, 2013

Marco,

What are the reasons to discontinue DSV version? Are you now installing
version-specific modules of your products?

Cheers,
Jordi

2013/9/5 Marco Lovato notifications@github.com

DSV version was discontinued :-)


Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-23793219
.

@lovato
Copy link
Collaborator

lovato commented Sep 7, 2013

No, no.
We had 2 localshops, one for testing our packaging process, and other one
for real packages.
Since we kind of mastered the packaging, and found the django /admin path,
we no longer need the DSV version.
It was the very same localshop version installed on both.

Marco

[]s

Lovato

sent from GMail

On Wed, Sep 4, 2013 at 2:07 PM, Jordi Llonch notifications@github.comwrote:

Marco,

What are the reasons to discontinue DSV version? Are you now installing
version-specific modules of your products?

Cheers,
Jordi

2013/9/5 Marco Lovato notifications@github.com

DSV version was discontinued :-)


Reply to this email directly or view it on GitHub<
https://github.com/mvantellingen/localshop/issues/36#issuecomment-23793219>

.


Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-23806427
.

@llonchj
Copy link
Collaborator

llonchj commented Sep 8, 2013

Thanks @lovato. I am about to implement CI for the whole devel process in a platform. This is why I was curious about your process.

@mvantellingen mvantellingen removed this from the 0.5 milestone Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants