Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage #91

Merged
merged 5 commits into from
Dec 23, 2018
Merged

Fix coverage #91

merged 5 commits into from
Dec 23, 2018

Conversation

mvcds
Copy link
Owner

@mvcds mvcds commented Dec 23, 2018 •
edited
Loading

Proposed changes

For some reason, nyc has stopped merging its coverages.

Using it indirectly does the trick

Checklist

  • I have reviewed the most recent version of CONTRIBUTING to this repository
  • I have validated that lint and tests pass locally with my changes
  • I have added tests that prove the PR works (if appropriate)
  • I have covered at least 50% of the code
  • I have added necessary documentation (if appropriate)
  • I have merged the last version into my PR (if appropriate)
  • I have reviewed the PR and consider it to be small (to make reviewing it easier)
  • Select one from the following about your PR, it...
    • is a non-breaking change (patch)
    • adds functionality withouth breaking changes (minor)
    • cause existing functionalities to not work as expected (major)

@mvcds mvcds added the bug Something isn't working label Dec 23, 2018
@mvcds mvcds merged commit ba72b83 into master Dec 23, 2018
@mvcds mvcds deleted the fix-coverage branch December 23, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mvcds