avoid a "dump" panic on card ciphers #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ciphers storing a credit or debit card don't have a "Login" object, so we would panic in the "dump" command when attempting to print login fields such as the URL or password. For now, simply filter ciphers depending on whether Login exists. We should probably improve this command in the future, but for now at least it doesn't panic. While at it, stop using tabwriter for it. First, if one has hundreds of passwords stored, the command would seem to hang for tens of seconds, decrypting all secrets before printing the whole aligned table. Now, it prints each line as it goes. Not aligned anymore, but that's not a terrible thing either - some URLs can be very long and mess up the output. We also start obeying ^C properly in both the "dump" command and when reading a password. Before the fix, both would simply keep going until they were finished. Finally, update deps. Fixes #28.
|
Unclear why CI started failing, it's possible that the bitwarden APIs changed a bit, or the secret setup prevents PR builds from working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)