Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format: add nolint to rxCommentDirective #77

Merged
merged 1 commit into from
Jul 9, 2020
Merged

format: add nolint to rxCommentDirective #77

merged 1 commit into from
Jul 9, 2020

Conversation

Nivl
Copy link
Contributor

@Nivl Nivl commented Jul 9, 2020

gofumpt has been added to golangci-lint as of v1.28. Golangci-lint also has a nolintlint linter that makes sure the //nolint directives don't start with a space. This is conflicting with gofumpt that forces a space to be added.

This PR adds nolint to rxCommentDirective to make sure no spaces are added.

mvdan
mvdan approved these changes Jul 9, 2020
View reviewed changes
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Unfortunate that they chose yet another non-standard directive format, though, instead of the standard go:whatever.

@mvdan mvdan merged commit 4fd085c into mvdan:master Jul 9, 2020
@Nivl Nivl deleted the ml/nolint branch July 10, 2020 22:22
@Nivl Nivl mentioned this pull request Jul 10, 2020
Merged
@ccoVeille ccoVeille mentioned this pull request May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nivl @mvdan