Introduce BusConnection#request_name and Connection#object_server to replace #request_service #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Service class was serving client and server roles and its #root tree had ProxyObject or DBus::Object leaves respectively. User code should not instantiate it directly so the breakage will hopefully be small. The main motivation is fixing #69: serving more than one well-known service names. ObjectServer, the service-side successor, no longer has any name (BusConnection, as yet not existing Connection subclass, will have 0 or more well-known names in addition to its unique name) It is returned by Connection#object_server and by the deprecated Connection#request_service. ProxyService is returned by Connection#service. Internal changes: - Renaming `bus` to `connection` where appropriate, not all connections are to a bus (but not aiming to fix peer connections right now). - Object#@service is deprecated, surviving until I figure out the prefered API to manage object trees. Object#connection introduced. - Connection#@service is gone, use Connection#object_server. - No longer set our name to emitted signals, the bus will overwrite it to our unique name anyway.
Simplifying ObjectServer#unexport: obj.path is always set in its constructor, we don't need to check it And removing code duplication in Object.dbus_signal
Source: https://raw.githubusercontent.com/cockpit-project/cockpit/27cb665b5c135481f900dafac0c1b754ab91b5a0/src/ws/com.redhat.Cockpit.DBusTests.xml Its license is LGPL-2.1, same as ours
Move service_newapi.rb to mock-service/spaghetti-monster.rb
It must have been built with
./configure --enable-verbose-mode
bus.rb was way too big
NodeTree was formerly but shortly called TreeBase
should help the tiny coverage drop (some calls were made to the system library instead)
the path will always exist because it is fetched from an exported object coverage obsession
It is largely academic, noone uses /org/freedesktop/DBus/Local except dbus-daemon. The name was wrong, a destination is something else. coverage obsession
NOTE: BusConnection is WIP, its code still lives in Connection
TODO: yardoc note that a failure can still result in getting the name later
because it will kill by process name and it may kill unrelated ones too It is in practice always wrapped by with_private_bus which will kill the bus daemon, causing an EOF at our end and our main loop will quit anyway.
any value of the envvar will enable the debug logging
|
Known problem (@mchf) in OBS build there is no system bus, therefore
workaround: replace |
because they do not work when building RPMs in OBS To be replaced by session bus tests where we tell limited-session-bus.conf to disallow some names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #69: A connection can have more than one well-known name (the letter-dotted one), ruby-dbus doesn't support it.
#request_service assumes you always have one name for a service. Also, it tries to expose this name before you have a chance to
exportobjects. In the simpleDBus::Mainloop this will work but in other cases (Agama: with a timed EventMachine loop) there is a race.Solution
Introduce
BusConnection#request_name(can have 0 or more of them) andConnection#object_server(that exists before the name is exposed) to replace#request_service.Testing