-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entropy-mnemonic conversions #19
Conversation
Should we include test cases for private functions? (its kind of design antipatern) If so, how to do it with current includes and so on? |
If there are tests for private functions, they depend on current implementation. If you change the private implementation, these tests will break. For example tests for If you want to test private function, single underscore allows simple imports. |
Please see #22, thanks. |
24b6d07
to
013716c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related #26.
Waits until #21 is merged. #19 (comment) |
Updated from dev. Updated the program ( |
…rify` is fixed Too long mnemonic which was not validated causes `OverflowError: password is too long.` in `pbkdf2_hmac` during `_generate_seed`.
Detected bug #28. Added test in f0b267c, which will be failing until the bug is fixed.
|
superceded by #36 |
No description provided.