Task 56 reference comparision

[mvondracek]

No description provided.

[mvondracek]

Related #56

[codeclimate]

Code Climate has analyzed commit 49df870 and detected 18 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	15
Bug Risk	3

View more on Code Climate.

[sobuch]

could we increase the number of tests run in travis by defining this variable? since you mentioned before that travis can run up to 50 minutes, we might as well test it a bit more

[mvondracek]

Yes, sure, that var. is set in Travis web UI. This way, it can be changed without changing codebase. I’m afraid I have to change it from my account. I can do it in the afternoon when I get to my computer. Btw, if our fuzz script would use some similar env var. we could also fuzz on travis. :D like loop N times and return 0 on success, 1 on failure (crash due to fuzz).

…

-- Martin Vondráček 31. 10. 2019 v 10:39, sobuch <notifications@github.com>:

@sobuch commented on this pull request. In test-reference/test_mnemoniccli_reference.py: > + +try: + # noinspection PyPackageRequirements + from mnemonic import Mnemonic as TrezorMnemonic +except ImportError as e: + print('{}\nPlease make sure `trezor/python-mnemonic` is installed. See `install.sh`.'.format(e), file=sys.stderr) + sys.exit(1) + + +class TestMnemoniccliReference(TestMainBase): + """ + Tests mnemoniccli tool against reference implementation of `trezor/python-mnemonic`. + + https://github.com/trezor/python-mnemonic + """ + _ENV_SUBTEST_COUNT = os.getenv('PA193MNEMONICSLYTHERIN_REFERENCE_SUBTEST_COUNT') # type: Optional[str] could we increase the number of tests run in travis by defining this variable? since you mentioned before that travis can run up to 50 minutes, we might as well test it a bit more — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

[sobuch]

Ok, I will make new PR for that change in the fuzzer.