DB Optimization for save and validate #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have one big install that uses XForms and it was starting to get pretty slow. Upon further investigation, the cause was the save() and validate_attributes() methods in EAV, which due to getattr overloading were causing single DB queries for every attribute on an entity for each save. (actually * 2 because it was taking place both in save and validate)
For XForm installs with many forms and many fields this was turning into hundreds of single DB queries for every save.
This optimizes things by getting all the db values for an entity all at once when doing validation and saving.
Passes the django-eav tests as well as the very rigorous tests we have for that project, so I think it is an easy win for anybody.