Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breeze dark for Flowupload/ocDownloader/Scanner/epubreader/Weather/ocSMS apps? #119

Closed
e-alfred opened this issue Apr 22, 2020 · 4 comments

Comments

@e-alfred
Copy link

Hello, I maintain a few apps and users ask if the Breeze Dark theme works with those apps. Sadly I didn't test them, maybe you could help me with the theming?

Which app would you like to have styled:
Flowupload https://github.com/e-alfred/flowupload
ocDownloader https://github.com/e-alfred/ocdownloader
Scanner https://github.com/e-alfred/nextcloud-scanner
Epubreader https://github.com/e-alfred/epubreader
ocSMS https://github.com/nextcloud/ocsms
Weather https://github.com/nextcloud/weather

Your setup (please complete the following information): Nextcloud 18.0.3 / 19 Beta 4

@e-alfred
Copy link
Author

e-alfred commented Apr 22, 2020

I tested the apps listed above and it seems all work except ocDownloader.

@mwalbeck
Copy link
Owner

Hi,

Thanks for getting in touch, great to hear it more or less works. Currently I support flowupload, weather and ocsms, but ocsms could use a touch up. Yes, scanner and epubreader seems to work as is and I doubt epubreader would lend itself well to theming, other than what is provided in the app itself.

I'll have a good look at ocDownloader and add it to the list of supported apps.

@mwalbeck mwalbeck added this to the 18.0.14 milestone Apr 26, 2020
@e-alfred
Copy link
Author

e-alfred commented Apr 27, 2020

Epubreader doesn't need theming as it opens the file in a new tab/window anyway (and it has dark mode already) so it shouldn't be a problem. The Scanner app is just one modal window for selecting a few options and shouldn't be much of a problem either.

If you could add ocDownloader, that would be awesome!

mwalbeck added a commit that referenced this issue May 2, 2020
@mwalbeck
Copy link
Owner

mwalbeck commented May 2, 2020

Styling has been added in 18.0.14, which has just been released

@mwalbeck mwalbeck closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants