-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul style functions #141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the heads up. I'm excited to see this merged! And don't worry about killing in the |
Cool, I'll let this simmer for a little bit to make sure there's nothing I'm forgetting, in the mean time I've built the docs and put them up at http://stanford.edu/~mwaskom/software/seaborn-dev/index.html if you're interested. |
olgabot
pushed a commit
to olgabot/seaborn
that referenced
this pull request
Oct 2, 2014
Overhaul style functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively large change to the style machinery. To quote from the release notes:
axes_style
and :func:set_style
, :func:plotting_context
and :func:set_context
, and :func:color_palette
and :func:set_palette
. In each case, the pairs take the exact same arguments. The first function defines and returns the parameters, and the second sets the matplotlib defaults. Additionally, the first function in each pair can be used in awith
statement to temporarily change the defaults. Both the style and context functions also now accept a dictionary of matplotlib rc parameters to override the seaborn defaults, and :func:set
now also takes a dictionary to update any of the matplotlib defaults. See the :ref:tutorial <aesthetics_tutorial>
for more information.nogrid
style has been deprecated and changed towhite
for more uniformity (i.e. there are nowdarkgrid
,dark
,whitegrid
, andwhite
styles).This closes #121, closes #74, and closes #112.
Also @phobson this reverts the addition of the
gridweight
parameter. Becauseset()
andset_style()
accept anrc
dict with params to override the seaborn themes, it didn't seem necessary to have the additional layer of complexity where some but not all matplotlib parameters are aliased and get special treatment. Sorry if that breaks some code.This also standardizes the set of parameters that are part of a seaborn style and a seaborn context (and enforces independence between those groups), which should make it easy to integrate with the stylesheet functionality in matplotlib 1.4 (although to be honest I haven't looked too closely at that stuff).
I also took this opportunity to make some tweaks to the styles, with things like thinner gridlines and replacing black elements with dark gray where appropriate.
Because this required rerunning the test notebooks, this PR also includes a downsizing of the aesthetics and linear model notebooks. I'm keeping them around because a lot of links out there on the internet point at the nbviewer versions, but now they're brief introductions with links to the longer version in the online docs.