New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scatterplot function #1436
Merged
Merged
Add scatterplot function #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
==========================================
+ Coverage 94.17% 94.32% +0.15%
==========================================
Files 15 15
Lines 4240 4300 +60
==========================================
+ Hits 3993 4056 +63
+ Misses 247 244 -3
Continue to review full report at Codecov.
|
This was referenced Jun 13, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a scatterplot function that can set the color, size, and marker of the points based on semantic variables. Simple obvious example:
More examples to come.
Possible functionality to be added in future development:
lineplot
Ultimately, this should also replace the underlying scatter plotter in
regplot
(and thereforelmplot
), and perhaps more pressingly, should be used by default inpairplot
andjointplot
.In principle the API here will work fine in
FacetGrid
but, similar to the case with the categorical plots, the ordering and limits for the various semantic variables will need to be explicitly defined so it can be shared across the facets. There should be a higher-level function similar tofactorplot
to draw these plots onto aFacetGrid
. It will need a name. One would befacetplot
but that is very easily confused withfactorplot
.The presence of this function will make it awkward that size/style semantics cannot be used in the categorical scatterplot functions (
stripplot
/swarmplot
), but adding them would probably be too disruptive.Closes #315
To Do: