Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

update all deps #472

Closed
gruppjo opened this issue Jan 27, 2017 · 5 comments
Closed

update all deps #472

gruppjo opened this issue Jan 27, 2017 · 5 comments
Labels
generator - dependencies
Milestone
1.11.0

Comments

@gruppjo
Copy link
Contributor

gruppjo commented Jan 27, 2017 •
edited

deps and devdeps for generator and generated project https://github.com/mwaylabs/generator-m-ionic-demo according to #94
@gruppjo gruppjo added this to the 1.11.0 milestone Jan 27, 2017
@gruppjo gruppjo changed the title updated all deps update all deps Jan 27, 2017
gruppjo added a commit that referenced this issue Feb 1, 2017
@gruppjo
chore #472: update npm devDeps of generated project
9ec9808
@gruppjo
Copy link
Contributor Author

gruppjo commented Feb 1, 2017 •
edited

bower: angular 1.6, ui-router 1.x, ngCordova / ionic native?

gruppjo added a commit that referenced this issue Feb 1, 2017
@gruppjo
chore #472: update bower deps of generated project
86ac3dc
@MathiasTim
Copy link
Contributor

angular 1.6 -> ok
ui-router -> no idea if that works. I would stick to the version the ionic guys use in their latest release
ngCordova/ionic native -> no idea if ionic native is for angular1 based projects or not.

@lordgreg any idea?

@lordgreg
Copy link
Contributor

lordgreg commented Feb 3, 2017

I wouldn't switch to ionic-native at all. This is pretty big change and would cause more conflict between developers. Ionic native can be used with ng1 apps, however, I'm really not sure if all of the plugins used really return promises. Not that we later found an issue with plugin because one, which we should use, returns an Observable.

@gruppjo
Copy link
Contributor Author

gruppjo commented Feb 8, 2017

Thanks for your feedback, guys. I tried angular 1.6 and I got some issues where some routes didn't load, so I suggest we stick with angular 1.5.

@MathiasTim
Copy link
Contributor

yep, agree. Since Ionic is also depending of angularjs 1.5.3.

gruppjo added a commit that referenced this issue Feb 8, 2017
@gruppjo
chore #472: fix tests
5ec2a3a
gruppjo added a commit that referenced this issue Feb 15, 2017
@gruppjo
#472 update deps - yosay, yeoman-assert
5569987
@gruppjo gruppjo closed this as completed Feb 15, 2017
gruppjo added a commit that referenced this issue Feb 24, 2017
@gruppjo
chore() #472 - update deps: gulp shell, gulp changed, karma-spec-repo…
b816c67 
…rter now with caret
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
generator - dependencies
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
3 participants
@lordgreg @gruppjo @MathiasTim