Format observations with a comma thousands separator #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping, I have a few open PRs. |
|
Here's a test: |
|
The current version misbehaves on my computer (Italian locale), as both the thousands separator and the decimal separator become a comma: if we follow this path, it must be for all numbers. But more fundamentally, I don't know other scientific softwares whose output depend on the locale (all those in my typical workflow don't). And I'm not sure I should need to (know and) install some other scientists' locale to exactly reproduce her results. So I'm happy to have the thousands separator, but binding it to the user's locale should at the very minimum be switched by default. |
MaxGhenis
changed the title
|
OK, I removed locale-awareness. |
|
Thanks @MaxGhenis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31 using guidance from https://stackoverflow.com/a/10742904/1840471. This will format the observation count using a locale-aware thousands separator (comma or period).