Use Super instead of explicit class naming #129
Conversation
In this case, we can just use the bound method `self.__next__` instead of calling the unbound method of `type(self)` and giving `self` as the first parameter.
|
Oh, I should probably take a look at the other files, too. |
Just saying :) |
|
@PierreSelim I know that quite well. But by the same argumentation you should never refactor out common constants because the that would be “implicit” and thus “bad”. That's not the case here. The reason, at the positions I replaced it, the parent class has been used is because it was the parent class as given above. Therefore, it is quite explicit and to-the-point using a language construct with exactly that semantic meaning and use case. I want the parent class. Which is not necessarily This makes the code more reusable and easier changeable. |
|
I think the reason super wasn't used was just for historical reasons, I don't think it was around in really old days. Thanks for fixing, this has been merged. When it comes to docstrings, it seems like I hadn't documented it, but we sort-of settled on using the “Google style”, which isn't very strictly defined, but exemplified here. It's quite readable in the source code, and can also be parsed by the napoleon sphinx extension when producing html documentation (example: http://mwclient.readthedocs.io/en/latest/reference/site.html) I added a note about it to the readme: 29ef67b |
Added some docstrings where appropriate as well.
Fixes #127