detect, warn and retry on nonce error #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retry on redis/memcached connection error, which looks like a nonce reuse
https://phabricator.wikimedia.org/T106066
indicates that while the text of the error message is perhaps poor (in that it should propagate or better communicate the upstream error from memcached or redis), but that fundamentally this is not something that the mediawiki folks seem inclined to change on the server side.
https://phabricator.wikimedia.org/T109173
indicates that the error is well known to the pywikibot code, and that they've addressed it via
https://gerrit.wikimedia.org/r/#/c/289582/