Improve User-Agent and documentation #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the helper method is not needed. As the preferred grammar is now stated it is easy for consumers to produce correct user agents. If a tool needs more flexibility one can use An alternative would be to allow passing tuples: |
pyfisch
commented
Dec 22, 2018
danmichaelo
reviewed
Aug 2, 2019
Use and recommend format from RFC 7231. Give examples for custom User-Agent strings. Closes #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use and recommend format from RFC 7231.
Give examples for custom User-Agent strings.
Closes #49