Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: py34 references #243

Merged
merged 1 commit into from Dec 12, 2019
Merged

remove: py34 references #243

merged 1 commit into from Dec 12, 2019

Conversation

marcfrederick
Copy link
Member

Support for Python 3.4 is stated in multiple places and already tested by the tox.ini

@waldyrious
Copy link
Member

This had been added before, in 22ac6ec. It was later removed in 737e7cc.

Can you point to the places where support for Python 3.4 is claimed? We probably should remove them.

@marcfrederick marcfrederick changed the title add: python34 to setup.py .travis.yml remove: py34 references Dec 11, 2019
@marcfrederick
Copy link
Member Author

@waldyrious I've updated this pull request to remove the references to Python 3.4 instead.

@waldyrious
Copy link
Member

Thanks, @marcfrederick! Can you just fix the commit message? It currently says "remove: py37 references" but it should be "remove: py34 references" instead.

@marcfrederick
Copy link
Member Author

Done @waldyrious

@waldyrious waldyrious merged commit 472ceb8 into mwclient:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants