Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Improve anchors in user/connecting.rst #246

Merged
merged 2 commits into from May 28, 2020
Merged

Docs: Improve anchors in user/connecting.rst #246

merged 2 commits into from May 28, 2020

Conversation

waldyrious
Copy link
Member

@waldyrious waldyrious commented Feb 3, 2020 •
edited

  • Improve anchors in user/connecting.rst
    • Move the auth anchor to be above the correct section
    • Add missing anchors so all sections have them
    • Add blank line above the old_login anchor and use hyphen instead of _.
  • Remove backticks in anchor names, for consistency

@waldyrious
Docs: Improve anchors in user/connecting.rst
b91211f 
- Move the auth anchor to be above the correct section
- Add missing anchors so all sections have them
- Add blank line above the old_login anchor and use hyphen instead of _.
@waldyrious
Copy link
Member Author

Note: the auth anchor was actually in use in

mwclient/docs/source/user/page-ops.rst

Line 12 in 472ceb8

:ref:`the section on authenticating <auth>`.

@danmichaelo danmichaelo merged commit f960d85 into master May 28, 2020
@danmichaelo
Copy link
Member

Awesome!

@danmichaelo danmichaelo deleted the docs-anchors branch May 28, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waldyrious @danmichaelo