Fix editing section zero

[ghost]

Currently, Page.text() correctly allows retrieving only section 0. However, Page.edit() (internally, Page._edit()) treats 0 as a falsy value and fails to set the section key in the data object sent to the API, meaning it's very feasible for users to retrieve section 0 and accidentally overwrite the entire page with only its contents.

This PR changes the comparison to the more explicit is not None used elsewhere.

[waldyrious]

@1bakedpotato I hope you don't mind, but I'll restore the original title and description of this PR. Otherwise it would look quite puzzling in the issue tracker.

[waldyrious]

@danmichaelo is this something we should merge? I haven't touched this code in a while so I'm not sure.

[danmichaelo]

Yes, we should! Sorry I've not been very responsive for some time. Since the fork was deleted, I wasn't able to fetch the commit from @ghost anymore, but I will give credit in the changelog! eh, no, I can't, since the user is deleted as well 😮 Oh well, at least a reference to the PR then :/

[waldyrious]

@danmichaelo actually it is still possible to check out the pull request; GitHub keeps a copy of the branch stored in the target repository, which you can checkout locally via git fetch origin pull/PR_NUMBER/head:BRANCH_NAME; in this case, that would be:

git fetch origin pull/249/head:edit-section-zero

That's explained in this GitHub help article. Hope that helps for next time :)

[danmichaelo]

Hah, thanks, that's nice to know :) At least, I added credits to 1bakedpotato to https://github.com/mwclient/mwclient/releases/tag/v0.10.1