Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for http authentification #27

Merged
merged 1 commit into from Nov 15, 2013
Merged

Add support for http authentification #27

merged 1 commit into from Nov 15, 2013

Conversation

kyv
Copy link
Contributor

@kyv kyv commented Nov 15, 2013

Please merge this pull request which allows clients to set http authentification headers.

@kyv kyv mentioned this pull request Nov 15, 2013
Closed
@danmichaelo
Copy link
Member

Just to make sure I understand it right; the credentials you use with http auth are in general different from the ones you use for normal mediawiki login?

@kyv
Copy link
Contributor Author

kyv commented Nov 15, 2013

I my case yes, though I suppose there would exists configurations where they are identical. Maybe it is not clear but this authentication happens with the web server, apache, nginx, etc, through http headers.

@danmichaelo
Copy link
Member

Ok, no problem then. The patch seems fine, so I'll merge it. Thanks for pushing 👍

danmichaelo added a commit that referenced this pull request Nov 15, 2013
@danmichaelo
Merge pull request #27 from kyv/master
c80c1ca 
Add support for http authentification
@danmichaelo danmichaelo merged commit c80c1ca into mwclient:master Nov 15, 2013
@waldyrious
Copy link
Member

@kyv, please add a line about this new feature in the release notes.

@kyv
Copy link
Contributor Author

kyv commented Nov 16, 2013

OK here you go: #30

@waldyrious
Copy link
Member

Please note that #30 documents PR #29, but not this one (#27). Sorry if I induced some confusion, the messages were identical and could be mistaken for duplicates. Can you add a line for this one as well?

@kyv
Copy link
Contributor Author

kyv commented Nov 16, 2013

Correct. Sorry I confused the two threads.

@kyv
Copy link
Contributor Author

kyv commented Nov 19, 2013

I created a new pull request. Sorry for all the mistakes I'm somewhat new to pull requests on github. I hope its ok If not let me know I will fix it. #31

@waldyrious
Copy link
Member

Nah, Github's PR workflow is somewhat clunky IMO. Thanks :)

@waldyrious waldyrious added this to the v0.7 milestone Jun 22, 2014
danmichaelo added a commit that referenced this pull request Nov 23, 2014
@danmichaelo
Use Basic/Digest Auth from Requests
8bec560 
As suggested in #52
Original auth mechanism introduced in #27
This change should retain backwards compability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyv @danmichaelo @waldyrious