Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inheritance issue in __repr__() methods #308

Merged
merged 1 commit into from
Sep 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mwclient/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ def split_num(s):
}

def __repr__(self):
return "<Site object '%s%s'>" % (self.host, self.path)
return "<%s object '%s%s'>" % (self.__class__.__name__, self.host, self.path)

def get(self, action, *args, **kwargs):
"""Perform a generic API call using GET.
Expand Down
6 changes: 5 additions & 1 deletion mwclient/image.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,8 @@ def download(self, destination=None):
return self.site.connection.get(url).content

def __repr__(self):
return "<Image object '%s' for %s>" % (self.name.encode('utf-8'), self.site)
return "<%s object '%s' for %s>" % (
self.__class__.__name__,
self.name.encode('utf-8'),
self.site
)
12 changes: 10 additions & 2 deletions mwclient/listing.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,11 @@ def set_iter(self, data):
self._iter = six.itervalues(data['query'][self.result_member])

def __repr__(self):
return "<List object '%s' for %s>" % (self.list_name, self.site)
return "<%s object '%s' for %s>" % (
self.__class__.__name__,
self.list_name,
self.site
)

@staticmethod
def generate_kwargs(_prefix, *args, **kwargs):
Expand Down Expand Up @@ -202,7 +206,11 @@ def __init__(self, site, name, info=None, namespace=None):
GeneratorList.__init__(self, site, 'categorymembers', 'cm', **kwargs)

def __repr__(self):
return "<Category object '%s' for %s>" % (self.name.encode('utf-8'), self.site)
return "<%s object '%s' for %s>" % (
self.__class__.__name__,
self.name.encode('utf-8'),
self.site
)

def members(self, prop='ids|title', namespace=None, sort='sortkey',
dir='asc', start=None, end=None, generator=True):
Expand Down
6 changes: 5 additions & 1 deletion mwclient/page.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,11 @@ def resolve_redirect(self):
return target_page

def __repr__(self):
return "<Page object '%s' for %s>" % (self.name.encode('utf-8'), self.site)
return "<%s object '%s' for %s>" % (
self.__class__.__name__,
self.name.encode('utf-8'),
self.site
)

def __unicode__(self):
return self.name
Expand Down