Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the clientlogin method, mark login as deprecated #332

Merged
merged 1 commit into from May 18, 2024

Conversation

AdamWill
Copy link
Member

@AdamWill AdamWill commented May 6, 2024

I tried to make this as accurate as possible based on the method docstrings and the upstream docs.

@coveralls
Copy link
Collaborator

coveralls commented May 6, 2024

Coverage Status

coverage: 70.065%. remained the same
when pulling 35d8d02 on AdamWill:document-clientlogin
into 5d4ca88 on mwclient:master.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
Copy link
Member

@marcfrederick marcfrederick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@marcfrederick marcfrederick merged commit 30f0e5d into mwclient:master May 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants