Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering links by namespace not working #72

Merged
merged 2 commits into from Nov 17, 2014

Conversation

c-martinez
Copy link
Contributor

When listing links from a specific namespace, API was returning the following warning:

Unrecognized parameter: 'plnamespace'.

And links from any namespace were returned. Replaced by 'gplnamespace' and namespace filtering works again.

@danmichaelo
Copy link
Member

Thanks for spotting that! Just replacing the pl prefix with gpl will break the case when generator=False though. But having a look at the backlinks() it seems like this will work:

prefix = listing.List.get_prefix('pl', generator)
kwargs = dict(listing.List.generate_kwargs(prefix, namespace=namespace))

Give it a try

@c-martinez
Copy link
Contributor Author

Good point. The prefix is now set as you suggested.

danmichaelo added a commit that referenced this pull request Nov 17, 2014
Filtering links by namespace not working
@danmichaelo danmichaelo merged commit 65d9ee8 into mwclient:master Nov 17, 2014
@waldyrious waldyrious added this to the v0.7.1 milestone Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants