Fixed test build

mweststrate · Dec 20, 2018 · 0d1ba6f · 0d1ba6f
1 parent f132766
commit 0d1ba6f
Show file tree

Hide file tree

Showing 12 changed files with 171 additions and 148 deletions.
diff --git a/README.md b/README.md
@@ -155,6 +155,11 @@ Todo:
 * [ ] support `this.rvalProps(this.rvalProps() + 1)` -> `this.rvalProps(x => x + 1)`?
 * [ ] updaters `inc1`, `inc`, `push`, `set`, `delete`, `assign`, `toggle`
 * [ ] utils `assignVals`, `toJS
+* [ ] move `invariant` to preprocessors?
+* [ ] add `reference` to models?
+* [ ] host docs
+* [ ] contributing guide. `reserved` section in package.json!
+* [ ] add `toJS` on all model types
 
 Later
 * [ ] dynamically switch between hook and non-hook implementations (and explain differences)

diff --git a/docs/0_introduction/00_about.mdx b/docs/0_introduction/00_about.mdx
@@ -7,7 +7,7 @@ route: /introduction/introduction
 
 # About RVal
 
-RVal is a minimalistic, transparent programming library, heavily inspired by [MobX](http://mobx.js.org), 
+RVal is a minimalistic, transparent reactive programming library, heavily inspired by [MobX](http://mobx.js.org), 
 with the same core principle: _Everything that can be derived from state, should be derived. Automatically_.
 
 However, the goals are slightly different. RVal core principles include:
@@ -17,10 +17,16 @@ However, the goals are slightly different. RVal core principles include:
 * 🎯 **Convention driven**: An idiomatic way of working, that guides devs into the [Pit of Success](https://medium.com/@ricomariani/the-pit-of-success-cfefc6cb64c8)
 * 📦 **Embeddable**: A low level building block, that is small (~2KB minified gzipped) so that it can easily be embedded in existing libraries and frameworks as state management libraries.
 * 🐆 **Fast**: Rock solid performance, leveraging the battle tested algorithms of MobX.
-* ☔ **Versatile**: no dependencies, no modern syntax requirements, non-intrusive, applicable in most JavaScript based stacks
+* ☔ **Versatile**: no dependencies, no modern syntax or language requirements, non-intrusive, applicable in any ES5 JavaScript stack
 * 🎓 **Gradual learning curve**: Opt-in utilities that help with applying best practices
 * 💪 **Strongly typed**: Shouldn't need further explanation in 2019
 
 ## Quick example
 
-TODO
+TODO
+
+## Packages
+
+TODO
+
+Table, with name, goal, cdn, umdname, bundlesize
diff --git a/pkgs/core/core.ts b/pkgs/core/core.ts
@@ -357,10 +357,6 @@ function removeCallback(fns: Thunk[], fn: Thunk) {
   fns.splice(fns.indexOf(fn), 1) // TODO: defensive index check?
 }
 
-export function toJS(value) {
-  // convert, recursively, all own enumerable, primitive + vals values
-}
-
 export function isVal(value: any): value is Val {
   return typeof value === "function" && value[$RVal] instanceof ObservableValue
 }

diff --git a/pkgs/core/package.json b/pkgs/core/package.json
@@ -2,7 +2,7 @@
   "name": "@r-val/core",
   "private": false,
   "version": "0.0.1",
-  "description": "",
+  "description": "minimalistic, transparent reactive programming library",
   "main": "dist/core.js",
   "umd:main": "dist/core.umd.js",
   "unpkg": "dist/core.umd.js",
@@ -18,28 +18,47 @@
   "author": "Michel Weststrate",
   "license": "MIT",
   "dependencies": {},
-  "files": ["*.ts", "dist"],
+  "files": [
+    "*.ts",
+    "dist"
+  ],
   "devDependencies": {},
+  "reserved": [
+    "configurable",
+    "enumerable",
+    "writable",
+    "value",
+    "$RVal",
+    "rval",
+    "defaultContext",
+    "isVal",
+    "isDrv",
+    "deepfreeze",
+    "val",
+    "drv",
+    "sub",
+    "batch",
+    "batched",
+    "effect"
+  ],
   "mangle": {
     "reserved": [
+      "configurable",
+      "enumerable",
+      "writable",
+      "value",
+      "$RVal",
+      "rval",
+      "defaultContext",
+      "isVal",
+      "isDrv",
+      "deepfreeze",
       "val",
       "drv",
       "sub",
       "batch",
       "batched",
-      "deepfreeze",
-      "isVal",
-      "isDrv",
-      "defaultContext",
-      "rval",
-      "rview",
-      "useVal",
-      "useLocalVal",
-      "useLocalDrv",
-      "model",
-      "mapOf",
-      "arrayOf",
-      "updater"
+      "effect"
     ]
   }
-}
+}
diff --git a/pkgs/core/tests/scheduling.spec.ts b/pkgs/core/tests/scheduling.spec.ts
@@ -1,8 +1,7 @@
-import { val, sub, drv, batch, effect } from '@r-val/core'
+import { val, sub, drv, batch, effect, $RVal } from '@r-val/core'
 
-const RVAL = Symbol.for('$RVal')
 function getDeps(thing) {
-    return Array.from(thing[RVAL].listeners)
+    return Array.from(thing[$RVal].listeners)
 }
 
 async function delay(time) {
@@ -63,10 +62,10 @@ test("scheduling 1", async () => {
     await delay(50)
     expect(events.splice(0)).toEqual([    ])
 
-    if (y[RVAL].markDirty) {
+    if (y[$RVal].markDirty) {
         // only check on non-minified build
         // should be exactly one dependency
-        expect(getDeps(x)).toEqual([y[RVAL].markDirty])
+        expect(getDeps(x)).toEqual([y[$RVal].markDirty])
     }
     x(4)
     expect(events.splice(0)).toEqual([

diff --git a/pkgs/immer/immer.ts b/pkgs/immer/immer.ts
@@ -1,5 +1,5 @@
 import { rval, Val } from "@r-val/core"
-import produce, { Draft } from "immer"
+import { produce, Draft } from "immer"
 
 export function updater<T, U extends any[], R>(val: Val<T>,  updater: (draft: Draft<T>, ...args: U) => R): (...args: U) => R {
   return function(...args: U) {

diff --git a/pkgs/immer/package.json b/pkgs/immer/package.json
@@ -18,28 +18,38 @@
   "author": "Michel Weststrate",
   "license": "MIT",
   "dependencies": {},
-  "files": ["*.ts", "dist"],
+  "files": [
+    "*.ts",
+    "dist"
+  ],
   "devDependencies": {},
+  "peerDependencies": {
+    "immer": "^1.6.0"
+  },
+  "reserved": [
+    "updater",
+    "produce"
+  ],
   "mangle": {
     "reserved": [
+      "configurable",
+      "enumerable",
+      "writable",
+      "value",
+      "$RVal",
+      "rval",
+      "defaultContext",
+      "isVal",
+      "isDrv",
+      "deepfreeze",
       "val",
       "drv",
       "sub",
       "batch",
       "batched",
-      "deepfreeze",
-      "isVal",
-      "isDrv",
-      "defaultContext",
-      "rval",
-      "rview",
-      "useVal",
-      "useLocalVal",
-      "useLocalDrv",
-      "model",
-      "mapOf",
-      "arrayOf",
-      "updater"
+      "effect",
+      "updater",
+      "produce"
     ]
   }
-}
+}
diff --git a/pkgs/models/package.json b/pkgs/models/package.json
@@ -18,28 +18,39 @@
   "author": "Michel Weststrate",
   "license": "MIT",
   "dependencies": {},
-  "files": ["*.ts", "dist"],
+  "files": [
+    "*.ts",
+    "dist"
+  ],
   "devDependencies": {},
+  "reserved": [
+    "model",
+    "mapOf",
+    "arrayOf",
+    "invariant"
+  ],
   "mangle": {
     "reserved": [
+      "configurable",
+      "enumerable",
+      "writable",
+      "value",
+      "$RVal",
+      "rval",
+      "defaultContext",
+      "isVal",
+      "isDrv",
+      "deepfreeze",
       "val",
       "drv",
       "sub",
       "batch",
       "batched",
-      "deepfreeze",
-      "isVal",
-      "isDrv",
-      "defaultContext",
-      "rval",
-      "rview",
-      "useVal",
-      "useLocalVal",
-      "useLocalDrv",
+      "effect",
       "model",
       "mapOf",
       "arrayOf",
-      "updater"
+      "invariant"
     ]
   }
-}
+}
diff --git a/pkgs/package-template.json b/pkgs/package-template.json
diff --git a/pkgs/react/package.json b/pkgs/react/package.json
@@ -18,28 +18,12 @@
   "author": "Michel Weststrate",
   "license": "MIT",
   "dependencies": {},
-  "files": ["*.ts", "dist"],
-  "devDependencies": {},
-  "mangle": {
-    "reserved": [
-      "val",
-      "drv",
-      "sub",
-      "batch",
-      "batched",
-      "deepfreeze",
-      "isVal",
-      "isDrv",
-      "defaultContext",
-      "rval",
-      "rview",
-      "useVal",
-      "useLocalVal",
-      "useLocalDrv",
-      "model",
-      "mapOf",
-      "arrayOf",
-      "updater"
-    ]
-  }
-}
+  "peerDependencies": {
+    "react": "^16.0.0"
+  },
+  "files": [
+    "*.ts",
+    "dist"
+  ],
+  "devDependencies": {}
+}