Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue131 #134

Merged
merged 23 commits into from
Jul 8, 2022
Merged

Issue131 #134

merged 23 commits into from
Jul 8, 2022

Commits on Mar 21, 2022

  1. log exceptions to logger instead of STDOUT/ERR, put class under test, 

    fixed bugs that where found in the process

 - fixed bug in remove(String, String, String) leading to only every
second host key being removed
 - ensure that there is a SHA1-hash-instance to prevent
NullPointerExceptions
 - replaced all occurrences of STDOUT/ERR outputs in case of exceptions
with log entries
 - added a default method to Logger to allow passing the exception to be
logged with the message
 - put class under test
    @kimmerin
    kimmerin committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    729cfa0 View commit details
    Browse the repository at this point in the history

  2. added test class

    @kimmerin
    kimmerin committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    f6478c4 View commit details
    Browse the repository at this point in the history

  3. create the exception we expect to get the exception message of that 

    particular JVM
    @kimmerin
    kimmerin committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    a8457b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Merge branch 'mwiede:master' into issue131

    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    4874e37 View commit details
    Browse the repository at this point in the history

  2. use platform dependent linebreak for logging the stack trace 

    added log-framework-specific implementations of log(int, String,
Throwable) to pass the cause to the framework in a fitting way
added tests for all log frameworks that can be configured in a
programmatic way.
    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    f9ebecd View commit details
    Browse the repository at this point in the history

  3. added

    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    7e3442f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'issue131' of https://github.com/kimmerin/jsch into issu… 

    …e131
    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    07f89ac View commit details
    Browse the repository at this point in the history

  5. "normalize" line breaks

    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    fe48f29 View commit details
    Browse the repository at this point in the history

  6. enforce \r\n when printing linebreaks

    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    3a6d708 View commit details
    Browse the repository at this point in the history

  7. fixed test to check the line break between message and stacktrace (that 

    actually is system dependent)
    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    a09f716 View commit details
    Browse the repository at this point in the history

  8. make members final 

    use slf4j 1.x API for logging to keep backward compatibility
    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    48e11e5 View commit details
    Browse the repository at this point in the history

  9. use logger-method to log message with cause

    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    c17fc10 View commit details
    Browse the repository at this point in the history

  10. removed unnecessary System.out.println

    @kimmerin
    kimmerin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    281054c View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. fixed formatting

    @kimmerin
    kimmerin committed May 6, 2022
    Configuration menu
    Copy the full SHA
    7ef222a View commit details
    Browse the repository at this point in the history

  2. reordered switch statement

    @kimmerin
    kimmerin committed May 6, 2022
    Configuration menu
    Copy the full SHA
    bed0768 View commit details
    Browse the repository at this point in the history

  3. use try-with-resource

    @kimmerin
    kimmerin committed May 6, 2022
    Configuration menu
    Copy the full SHA
    8db5889 View commit details
    Browse the repository at this point in the history

  4. make use of the import

    @kimmerin
    kimmerin committed May 6, 2022
    Configuration menu
    Copy the full SHA
    a7937a0 View commit details
    Browse the repository at this point in the history

  5. use short form instead of FQN

    @kimmerin
    kimmerin committed May 6, 2022
    Configuration menu
    Copy the full SHA
    ca27cdf View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. removed unused exception from method signature

    @kimmerin
    kimmerin committed May 9, 2022
    Configuration menu
    Copy the full SHA
    1f16716 View commit details
    Browse the repository at this point in the history

  2. removed unnecessary suppressWarning

    @kimmerin
    kimmerin committed May 9, 2022
    Configuration menu
    Copy the full SHA
    4a8bd79 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. throw a RuntimeException (to keep the signature of KnownHost's 

    constructor) if the HMAC-SHA1-class can't be instantiated.
    @kimmerin
    kimmerin committed May 10, 2022
    Configuration menu
    Copy the full SHA
    08c9a5c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. removed unused import. Get rid off other compiler warnings that kept me 

    from seeing this earlier
    @kimmerin
    kimmerin committed May 11, 2022
    Configuration menu
    Copy the full SHA
    89d84ca View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. removed unused member

    @kimmerin
    kimmerin committed May 13, 2022
    Configuration menu
    Copy the full SHA
    d1d9867 View commit details
    Browse the repository at this point in the history