Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit encoding argument in read_text() #253

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Mar 30, 2024

Closes #252
Closes #285

Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/itables.git@explicit_utf8_encoding

(this requires nodejs, see more at Developing ITables)

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (353be33) to head (43002ce).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files          27       27           
  Lines        1171     1171           
=======================================
  Hits         1126     1126           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts merged commit 1b42c1c into main Jun 7, 2024
14 checks passed
@mwouts mwouts deleted the explicit_utf8_encoding branch June 7, 2024 23:26
Repository owner deleted a comment Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError while set "connected=False" UnicodeDecodeError in JupyterLab Desktop
2 participants