1.1.4 #243
Merged
1.1.4 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the isinstance check `if isinstance(app.contents_manager_class, TextFileContentsManager):` will always fail because app.contents_manager_class is not an instance. Changing this to `if issubclass(app.contents_manager_class, TextFileContentsManager):` will allow others to extend. https://www.codevscolor.com/python-isinstance-issubclass/
Bash kernel also has argv[0]==python...
Fixes #240
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=========================================
- Coverage 99.23% 99.14% -0.1%
=========================================
Files 65 66 +1
Lines 6176 6286 +110
=========================================
+ Hits 6129 6232 +103
- Misses 47 54 +7
Continue to review full report at Codecov.
|
as it fails on travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
--set-kernelin Jupytext command line (md to ipynb conversion does not create kernelspec in ipynb #230)--to scriptor--to auto(Jupytext --to script #240)BugFixes