-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.1.4 #243
Commits on Jun 4, 2019
-
changing isinstance to issubclass
the isinstance check `if isinstance(app.contents_manager_class, TextFileContentsManager):` will always fail because app.contents_manager_class is not an instance. Changing this to `if issubclass(app.contents_manager_class, TextFileContentsManager):` will allow others to extend. https://www.codevscolor.com/python-isinstance-issubclass/
Configuration menu - View commit details
-
Copy full SHA for 63b7935 - Browse repository at this point
Copy the full SHA 63b7935View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27612c4 - Browse repository at this point
Copy the full SHA 27612c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1aad22 - Browse repository at this point
Copy the full SHA c1aad22View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7fc47c - Browse repository at this point
Copy the full SHA c7fc47cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a21384 - Browse repository at this point
Copy the full SHA 2a21384View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad19f61 - Browse repository at this point
Copy the full SHA ad19f61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c4b027 - Browse repository at this point
Copy the full SHA 7c4b027View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0beb5f6 - Browse repository at this point
Copy the full SHA 0beb5f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7384ee - Browse repository at this point
Copy the full SHA e7384eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c0c03e - Browse repository at this point
Copy the full SHA 0c0c03eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4844af - Browse repository at this point
Copy the full SHA e4844afView commit details -
Configuration menu - View commit details
-
Copy full SHA for c73150f - Browse repository at this point
Copy the full SHA c73150fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ea31a6 - Browse repository at this point
Copy the full SHA 4ea31a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8df463c - Browse repository at this point
Copy the full SHA 8df463cView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb84c87 - Browse repository at this point
Copy the full SHA eb84c87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02d4cd1 - Browse repository at this point
Copy the full SHA 02d4cd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8a2311 - Browse repository at this point
Copy the full SHA f8a2311View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4082197 - Browse repository at this point
Copy the full SHA 4082197View commit details -
Configuration menu - View commit details
-
Copy full SHA for 841b3c8 - Browse repository at this point
Copy the full SHA 841b3c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 271b7b0 - Browse repository at this point
Copy the full SHA 271b7b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4161ac - Browse repository at this point
Copy the full SHA a4161acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ae4053 - Browse repository at this point
Copy the full SHA 9ae4053View commit details -
Configuration menu - View commit details
-
Copy full SHA for be2bdb6 - Browse repository at this point
Copy the full SHA be2bdb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68c4baa - Browse repository at this point
Copy the full SHA 68c4baaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58ce39c - Browse repository at this point
Copy the full SHA 58ce39cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 530b168 - Browse repository at this point
Copy the full SHA 530b168View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.