SCLI-2 #8
Merged
SCLI-2 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouline
suggested changes
Aug 10, 2018
| dispatch_async(self.queue, ^{ | ||
| [weakSelf send:message]; | ||
| }); | ||
| [self send:[[[SPIDropKeysRequest alloc] init] toMessage]]; |
There was a problem hiding this comment.
Why are you no longer doing this asynchronously? What changed?
There was a problem hiding this comment.
The problem is as follows.
When pairing with a terminal from an iOS library, if you confirm pairing from the POS but rejected from the terminal, the terminal shows a disconnected status when it should unpair itself from the terminal.
Terminal disconnected before unpaired.
There was a problem hiding this comment.
OK, fair enough. Just checking that it was an intentional change.
gouline
approved these changes
Aug 14, 2018
gouline
force-pushed
the
master
branch
14 times, most recently
from
758c245
to
4b47352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://payments51.atlassian.net/browse/SCLI-2