Fix #19: Yosemite dark mode icons #20
Conversation
|
Nice work here, was just about to suggest a PR. In future probably just worth submitting a PR and issue in a oner. |
|
Can I see a (Retina) screenshot of a before and after here? Thanks! |
|
Yeah, I submitted the issue and then thought I might just have a go myself! I think there used to be a way to convert issues to PRs, but I couldn't find it. Here are the apps side-by-side, left is old and right is new. |
|
@joerick Do you have a copy of Sketch, by any chance? The originals for these are vector images so would be good to modify them. |
|
Sorry, I don't. I did these in photoshop by using the icon@2x as a mask, so I'm pretty confident that the bitmaps are as sharp as can be! |
|
@joerick Can you rebase on |
Template images use only the alpha channel, allowing the OS to choose the correct color for the situation. This fixes use of the icon in Yosemite dark mode. Issue mxcl#19.
|
Your new icons look good to me. Have cherrypicked my template commit onto the new master. |
Fix #19: Yosemite dark mode icons
I've tested this on Yosemite and on Mavericks.