Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status item not compatible with Yosemite Dark Mode #19

Closed
joerick opened this issue Nov 4, 2014 · 2 comments
Closed

Status item not compatible with Yosemite Dark Mode #19

joerick opened this issue Nov 4, 2014 · 2 comments

Comments

@joerick
Copy link
Contributor

joerick commented Nov 4, 2014

image

In Yosemite 'template' images are used so they can be adapted to either light or dark mode.
@joerick
Copy link
Contributor Author

joerick commented Nov 4, 2014

The fix may be as simple as calling setTemplate:YES on the images before giving them to the NSStatusItem here.

That would not work with the coloured icons that are used for status, though. Perhaps for those a different asset (that doesn't have white aliasing around the edges) would suffice.

joerick added a commit to joerick/Audioscrobbler.app that referenced this issue Nov 4, 2014
@joerick
Use template NSImages for the NSStatusItem
5c228a0 
Template images use only the alpha channel, allowing the OS to choose
the correct color for the situation. This fixes use of the icon in
Yosemite dark mode. Issue mxcl#19.
@joerick
Copy link
Contributor Author

joerick commented Nov 4, 2014

PR here: #20

joerick added a commit to joerick/Audioscrobbler.app that referenced this issue Nov 4, 2014
@joerick
Use template NSImages for the NSStatusItem
eea84bf 
Template images use only the alpha channel, allowing the OS to choose
the correct color for the situation. This fixes use of the icon in
Yosemite dark mode. Issue mxcl#19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joerick