-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add EiskaltDC++ to section "Projects which use MXE" #1127
Conversation
👍 I have updated MXE build instructions of EiskaltDC++. Additional suggestions:
|
Ok, I'll do it later. |
Thanks! |
add EiskaltDC++ to section "Projects which use MXE"
Done. |
From your PR #1050:
Where is install directory for apps? EiskaltDC++ is installing icons, scripts, sounds into "./EiskaltDC++/resources" directory, binaries into "./EiskaltDC++" directory, dictionaries into "./EiskaltDC++/aspell" directory.
|
I like this idea. Does EiskaltDC++ work with such directories? |
What?
in EiskaltDC++.mk file. |
I mean, does it work with the following layout:
? |
Of course. Why not?
and qt.conf file in apps/EiskaltDC++ directory:
Install script of EiskaltDC++: https://gist.github.com/pavelvat/87153221bd2463023007 |
TARGET x86_64-w64-mingw32.shared currently produce wrong executables for EiskaltDC++ (It is working in wine, but don't work under native Windows). Quick workaround to fix this commented this two lines: https://github.com/eiskaltdcpp/eiskaltdcpp/blob/master/dcpp/Util.cpp#L174-L175 |
Also need -DPERL_REGEX=OFF because EiskaltDC++ required build pcre.mk with option |
Can we add |
It is not good idea, because many applications not required libpcrecpp.dll which requires addititional dependency from libstdc++-6.dll.
Is that possible? qtbase.mk depends on pcre.mk. |
Seems commit b4decd3 broke linking with libaspell-15.dll: file is missing libdl.dll.a |
Why do they get additional dependency? PCRE already install multiple DLLs and multiple pc-files:
Nothing will change for an application using libpcre-1.dll if PCRE installs also C++ libpcrecpp.dll. |
Plugins can change features of existing packages, not only add new packages. See gcc52 plugin: it changes gcc version from 4.9 to 5.2. |
If so you can add --enable-cpp to pcre.mk. |
I honestly don't remember. This was 2009. :-) Whatever my reasons were at that time - they almost certainly don't apply anymore. Feel free to enable C++ support in pcre and check if that makes any trouble. |
Application EiskaltDC++ requires pcre with C++ support. See mxe#1127 (comment)
I'm building all packages for 8aa92bb |
This doesn't make it the best candidate for an apps plugin - I imagined a large part of the appeal of those would be the static build? |
Build of EiskaltDC++ for TARGET=i686-w64-mingw32.static has final linked errors after building of 100% sources with plugins of databases: qsql_sqlite, qsql_tds, qsql_odbc, qsql_psql. |
Can you embed resources and aspell into executable? Qt has qrc for this purpose.
At least all dependencies in one directory. It is also easy to use. By the way, does EiskaltDC++ have an installer? NSIS provides easy way to make an installer. |
Maybe in future...
It is not important and can not improve the usability. More over, the portable version of EiskaltDC++ create settings configs in a directory of launch, so for usability only static file eiskaltdcpp-qt.exe is not enought, also required a directory for settings files. So "directory with settings + static build of eiskaltdcpp-qt.exe" or "directory with settings + shared build of eiskaltdcpp-qt.exe + dll dependencies" is not important for usability.
Of course: |
Agreed. Just few more ideas. Settings can be stored in registry. QBittorrent also remembers its configuration, so it must be storing settings either to file or to registry.
Can you add generation of the installer to mk file, please? MXE has nsis. |
Only file associations and info about program.
Applications for Windows are saving settings configs to standard configs directory: Portable versions of software must save settings to directory with *.exe file, because application can be launched on other computers.
Of course. |
Application EiskaltDC++ requires pcre with C++ support. See mxe#1127 (comment)
Command $(TARGET)-makensis don't available on x86_64-w64-mingw32.static and x86_64-w64-mingw32.shared, because nsis.mk have supports only i686-w64-mingw32.static and i686-w64-mingw32.shared targets. |
@pavelvat, I use |
What about this case: settings.mk
Why does nsis.mk install Linux ELF-binaries into |
Additionally you can build
NSIS is similar to a compiler, because it has target. Target of NSIS doesn't need to be equal to target of a compiler which produced executables being packed by NSIS. However 32bit installer looks as if it installs 32bit executables, so it can be misleading, so we'd better to fix NSIS for |
Application EiskaltDC++ requires pcre with C++ support. See mxe#1127 (comment)
No description provided.