Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libraw: library for processing raw image files #2481

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

mardy
Copy link
Contributor

@mardy mardy commented Apr 11, 2020

Let's keep jasper disabled for now, as it produces build errors:

/mnt/Lavoro/mxe/mxe/usr/x86_64-w64-mingw32.shared/include/jasper/jas_math.h:
In function 'bool jas_safe_intfast32_mul(int_fast32_t, int_fast32_t,
                                         int_fast32_t*)':
/mnt/Lavoro/mxe/mxe/usr/x86_64-w64-mingw32.shared/include/jasper/jas_math.h:241:12:
error: 'INT_FAST32_MAX' was not declared in this scope
    if (x > INT_FAST32_MAX / y) {
                    ^

It's not a required dependency, but we might want to add it later if
someone asks for it (and can provide a solution).

@mardy
Copy link
Contributor Author

mardy commented Apr 11, 2020

I added a test, and verified that the produced binary works in a Windows machine.

@mardy mardy changed the title WIP: Add libraw: library for processing raw image files Add libraw: library for processing raw image files Apr 11, 2020
@tonytheodore tonytheodore mentioned this pull request Apr 16, 2020
@mardy
Copy link
Contributor Author

mardy commented May 23, 2020

Hi! Is there anything else I could do to help get this merged?

src/libraw.mk Outdated Show resolved Hide resolved
src/libraw.mk Outdated Show resolved Hide resolved
src/libraw.mk Outdated Show resolved Hide resolved
@mardy mardy force-pushed the libraw branch 2 times, most recently from 3f85cf3 to 8d8ddd6 Compare June 3, 2020 21:25
src/libraw.mk Outdated Show resolved Hide resolved
src/libraw.mk Outdated Show resolved Hide resolved
src/libraw.mk Outdated Show resolved Hide resolved
@mardy mardy force-pushed the libraw branch 2 times, most recently from 73079e2 to 8ae28d6 Compare June 4, 2020 19:59
src/libraw.mk Outdated Show resolved Hide resolved
Let's keep jasper disabled for now, as it produces build errors:

    /mnt/Lavoro/mxe/mxe/usr/x86_64-w64-mingw32.shared/include/jasper/jas_math.h:
    In function 'bool jas_safe_intfast32_mul(int_fast32_t, int_fast32_t,
                                             int_fast32_t*)':
    /mnt/Lavoro/mxe/mxe/usr/x86_64-w64-mingw32.shared/include/jasper/jas_math.h:241:12:
    error: 'INT_FAST32_MAX' was not declared in this scope
        if (x > INT_FAST32_MAX / y) {
                        ^

It's not a required dependency, but we might want to add it later if
someone asks for it (and can provide a solution).
@tonytheodore
Copy link
Member

Thanks!

The beta version is also successful with:

make update-package-libraw GITHUB_TAG_FILTER=any-no-match-string

but bypassing the default should be clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants