-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libraw: library for processing raw image files #2481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a test, and verified that the produced binary works in a Windows machine. |
mardy
changed the title
WIP: Add libraw: library for processing raw image files
Add libraw: library for processing raw image files
Apr 11, 2020
Closed
Hi! Is there anything else I could do to help get this merged? |
tonytheodore
reviewed
Jun 3, 2020
tonytheodore
reviewed
Jun 3, 2020
tonytheodore
reviewed
Jun 3, 2020
mardy
force-pushed
the
libraw
branch
2 times, most recently
from
June 3, 2020 21:25
3f85cf3
to
8d8ddd6
Compare
tonytheodore
reviewed
Jun 4, 2020
tonytheodore
reviewed
Jun 4, 2020
tonytheodore
reviewed
Jun 4, 2020
mardy
force-pushed
the
libraw
branch
2 times, most recently
from
June 4, 2020 19:59
73079e2
to
8ae28d6
Compare
tonytheodore
reviewed
Jun 5, 2020
Let's keep jasper disabled for now, as it produces build errors: /mnt/Lavoro/mxe/mxe/usr/x86_64-w64-mingw32.shared/include/jasper/jas_math.h: In function 'bool jas_safe_intfast32_mul(int_fast32_t, int_fast32_t, int_fast32_t*)': /mnt/Lavoro/mxe/mxe/usr/x86_64-w64-mingw32.shared/include/jasper/jas_math.h:241:12: error: 'INT_FAST32_MAX' was not declared in this scope if (x > INT_FAST32_MAX / y) { ^ It's not a required dependency, but we might want to add it later if someone asks for it (and can provide a solution).
Thanks! The beta version is also successful with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's keep jasper disabled for now, as it produces build errors:
It's not a required dependency, but we might want to add it later if
someone asks for it (and can provide a solution).