Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App broken updating just now #270

Closed
jtagcat opened this issue Jan 2, 2022 · 7 comments · Fixed by #271
Closed

App broken updating just now #270

jtagcat opened this issue Jan 2, 2022 · 7 comments · Fixed by #271

Comments

@jtagcat
Copy link
Contributor

jtagcat commented Jan 2, 2022 •
edited
Loading

cc @mxpv

running docker

time="2022-01-02T12:33:17Z" level=fatal msg="failed to load configuration file" error="failed to read config file: config.toml: open config.toml: no such file or directory"
@mxpv
Copy link
Owner

mxpv commented Jan 2, 2022

no such file or directory

Something wrong with path to the configuration file.

@jtagcat
Copy link
Contributor Author

jtagcat commented Jan 2, 2022

It works with v2.4.0; breaks when changing image to v2.4.1.

    volumes:
      - /barfoo:/app/data:rw
      - /foobar/config.toml:/app/config.toml:ro

@mxpv
Copy link
Owner

mxpv commented Jan 2, 2022

Can you try this:

- /foobar/config.toml:/config.toml:ro

@jtagcat
Copy link
Contributor Author

jtagcat commented Jan 2, 2022 •
edited
Loading

f337f6c#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557 removed WORKDIR /app

main.go uses just 'config.toml' (relative to pwd, what defaults to / otherwise)

@jtagcat
Copy link
Contributor Author

jtagcat commented Jan 2, 2022

Can you try this:

- /foobar/config.toml:/config.toml:ro

works

@mxpv mxpv closed this as completed in 16315c0 Jan 2, 2022
@mxpv
Copy link
Owner

mxpv commented Jan 2, 2022

Thanks, I've updated docker-compose example

@jtagcat
Copy link
Contributor Author

jtagcat commented Jan 2, 2022

Thanks, I've updated docker-compose example

I'd suggest enabling /app/config.toml instead, as users have already mounted /app/data and /app/config.toml. There isn't a reason to break people's configs.

@jtagcat jtagcat mentioned this issue Jan 2, 2022
Merged
jtagcat added a commit to jtagcat/podsync that referenced this issue Jan 2, 2022
@jtagcat
readd WORKDIR /app
97685e8 
`config.toml` uses relative path, from the current directory, `$PWD` by default is `/`.

commit f337f6c
removed `WORKDIR /app`, and `/config.toml` was used instead of `/app/config.toml`.
The change was breaking, unexpected and undocumented.
As users already mount `/app/config.toml`, revert to using it.

Revert 16315c0
(what was workaround for breaking change,
though there is no need to break anything here)

Closes mxpv#270
jtagcat added a commit to jtagcat/podsync that referenced this issue Jan 2, 2022
@jtagcat
readd WORKDIR /app
34c708d 
`config.toml` uses relative path, from the current directory, `$PWD` by default is `/`.

commit f337f6c
removed `WORKDIR /app`, and `/config.toml` was used instead of `/app/config.toml`.
The change was breaking, unexpected and undocumented.
As users already mount `/app/config.toml`, revert to using it.

Revert 16315c0
(what was workaround for breaking change,
though there is no need to break anything here)

Closes mxpv#270

+ requested: podsync located again at /app/podsync, instead of /podsync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixup: Dockerfile: reinstate location of config.toml jtagcat/podsync
2 participants
@mxpv @jtagcat